config: generate model code from json schema #4879
Open
+783
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposing that the first step towards implementing OpenTelemetry Configuration is to produce the model code from the json schema. I did a quick search for tools available to do this and came across datamodel-codegen which seems to do what i expected. Will open following pull requests (in draft) to use this model code, i just want to keep these as clearly separated as possible to make reviewing them easier. Signed-off-by: alex boten <[email protected]>
xrmx
reviewed
Jan 16, 2026
| formatters = ["ruff-format", "ruff-check"] | ||
| use-standard-collections = true | ||
| use-schema-description = true | ||
| use-title-as-name = true |
Contributor
There was a problem hiding this comment.
Suggested change
| use-title-as-name = true | |
| use-title-as-name = true | |
| use-union-operator = true |
Does this make a difference? It should be the default but the pipe is not used for optionals
Member
There was a problem hiding this comment.
I tried this but Python 3.9 doesn't support | and with use-union-operator set we'd generate something like
AlwaysOffSampler: TypeAlias = dict[str, Any] | Nonewith it disabled, we generate which works in 3.9
AlwaysOffSampler: TypeAlias = Optional[dict[str, Any]]I also updated the target-python-version to 3.10 as datamodel-codegen's validation wants 3.10+.
… into codeboten/generate-config-model-from-schema
Member
|
I'm helping pick this up from @codeboten - I've opened the following PR to their branch that fixes the codegeneration tooling and also sets the use-union-operator option @xrmx suggested: |
…el-from-schema fix code-generation command and regenerate models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proposing that the first step towards implementing OpenTelemetry Configuration is to produce the model code from the json schema. I did a quick search for tools available to do this and came across datamodel-codegen which seems to do what i expected.
Will open following pull requests (in draft) to use this model code, i just want to keep these as clearly separated as possible to make reviewing them easier.
Related to #3631
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
This PR is just code generation, no tests have been added just yet
Checklist: